Attempt to fix cache-related bugs #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I haven't been able to reproduce this bug myself, so I'll wait for someone else to give it a try before merging, but it looks great and your help is appreciated. |
|
You're very welcome - I'm glad I was able to help! I had started working on a Dockerfile or Vagrantfile to reproduce the bugs, but it turned out to be easy to reproduce in Ubuntu 15.10 on my laptop :) |
|
Someone over at #238 who experienced the bug before your changes no longer does, so I think we're good to go. Thanks! |
|
Great! I'm submitting another pull request to fix the apparent problem someone else had over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix most (maybe even all?) of the bugs associated with cache files. Namely #238, #313, and #399. The features added are: