Remove shell=True
#467
Merged
Remove shell=True
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchow
force-pushed
the
shell-equals-true
branch
from
09fe1ab
to
e4a5e9e
Compare
suchow
force-pushed
the
shell-equals-true
branch
from
e4a5e9e
to
2bb9f65
Compare
QuLogic
reviewed
Aug 26, 2017
| @@ -37,20 +37,24 @@ def timing_test(corpus="0.1.0"): | |||
| for file in os.listdir(corpus_path): | |||
| filepath = os.path.join(corpus_path, file) | |||
| if ".md" == filepath[-3:]: | |||
| subprocess.call( | |||
| "proselint {} >/dev/null".format(filepath), shell=True) | |||
| subprocess.call(["proselint", filepath, ">/dev/null"]) | |||
There was a problem hiding this comment.
This doesn't really work. Without using shell=True, the > is just another character, so you're just passing an extra file name. You can redirect using something like stdout=subprocess.DEVNULL.
| @@ -2,4 +2,4 @@ | |||
|
|
|||
| import subprocess | |||
|
|
|||
| subprocess.call("proselint --debug >/dev/null", shell=True) | |||
| subprocess.call(["proselint", "--debug", ">/dev/null"]) | |||
There was a problem hiding this comment.
The same thing applies here (though you've added shell=True back on master).
|
@QuLogic Thanks for the review! Would you be interested & willing to open a PR that does all this correctly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.