Tests for existence_check in tools.py #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for this. Can you squash these commits together? Otherwise, it looks ready to merge. |
|
@suchow Ok, I can squash them together once the current CI checks have completed |
updated docstrings added final newline based on pep checks updates to docstring based on pep257 updates to docstring based on pep8
joshmgrant
force-pushed
the
tools_existence_test_pr
branch
from
a147bd0
to
ef6107c
Compare
|
@joshmgrant Our test coverage is only 15% — lot's of room for improvement. I saw your blog and that you're knowledgeable about testing software. I'd be interested to hear your thoughts and suggestions about improving our testing of proselint. |
|
@suchow ow Thanks for reading my stuff! I'd love to give some suggestions for testing. I'll have a think and we can discuss further :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written a (basic!) test class for the
tools.existence_check()function. As this function is pretty widely used all over proselint, I thought having a test harness for it would help any future refactoring or bug fixing.