Fix Promise::when invocation order

amphp · Dec 23, 2016 · 44bc971 · 44bc971
1 parent bc1ae18
commit 44bc971
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 19 deletions.
diff --git a/lib/Internal/Placeholder.php b/lib/Internal/Placeholder.php
@@ -17,10 +17,10 @@ trait Placeholder {
 
     /** @var mixed */
     private $result;
-    
+
     /** @var callable|\Amp\Internal\WhenQueue|null */
     private $onResolved;
-    
+
     /**
      * @see \Interop\Async\Promise::when()
      */
@@ -63,27 +63,28 @@ private function resolve($value = null) {
             throw new \Error("Promise has already been resolved");
         }
 
-        $this->resolved = true;
         $this->result = $value;
 
-        if ($this->onResolved === null) {
-            return;
-        }
+        try {
+            while ($this->onResolved !== null) {
+                $onResolved = $this->onResolved;
+                $this->onResolved = null;
 
-        $onResolved = $this->onResolved;
-        $this->onResolved = null;
+                if ($this->result instanceof Promise) {
+                    $this->result->when($onResolved);
+                    return;
+                }
 
-        if ($this->result instanceof Promise) {
-            $this->result->when($onResolved);
-            return;
-        }
-
-        try {
-            $onResolved(null, $this->result);
-        } catch (\Throwable $exception) {
-            Loop::defer(static function () use ($exception) {
-                throw $exception;
-            });
+                try {
+                    $onResolved(null, $this->result);
+                } catch (\Throwable $exception) {
+                    Loop::defer(static function () use ($exception) {
+                        throw $exception;
+                    });
+                }
+            }
+        } finally {
+            $this->resolved = true;
         }
     }
 

diff --git a/test/WhenOrderTest.php b/test/WhenOrderTest.php
@@ -0,0 +1,30 @@
+<?php declare(strict_types = 1);
+
+namespace Amp\Test;
+
+use Amp\Deferred;
+
+class WhenOrderTest extends \PHPUnit_Framework_TestCase {
+    public function testWhenOrder() {
+        $this->expectOutputString("1234");
+
+        $deferred = new Deferred;
+        $promise = $deferred->promise();
+
+        $promise->when(function () use ($promise) {
+            $promise->when(function () {
+                printf("%d", 3);
+            });
+            printf("%d", 1);
+        });
+
+        $promise->when(function () use ($promise) {
+            $promise->when(function () {
+                printf("%d", 4);
+            });
+            printf("%d", 2);
+        });
+
+        $deferred->resolve();
+    }
+}