Check array index instead of error suppression

amphp · Aug 18, 2015 · f170ace · f170ace
1 parent 57c5cb6
commit f170ace
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/NativeReactor.php b/lib/NativeReactor.php
@@ -341,7 +341,7 @@ public function once(callable $callback, $msDelay, array $options = []) {
         $watcher->id = $watcherId = \spl_object_hash($watcher);
         $watcher->type = Watcher::TIMER_ONCE;
         $watcher->callback = $callback;
-        $watcher->cbData = @$options["cb_data"];
+        $watcher->cbData = isset($options["cb_data"]) ? $options["cb_data"] : null;
         $watcher->isEnabled = isset($options["enable"]) ? (bool) $options["enable"] : true;
         $watcher->keepAlive = isset($options["keep_alive"]) ? (bool) $options["keep_alive"] : true;
         $watcher->msDelay = round(($msDelay / 1000), 3);
@@ -379,7 +379,7 @@ public function repeat(callable $callback, $msInterval, array $options = []) {
         $watcher->id = $watcherId = \spl_object_hash($watcher);
         $watcher->type = Watcher::TIMER_REPEAT;
         $watcher->callback = $callback;
-        $watcher->cbData = @$options["cb_data"];
+        $watcher->cbData = isset($options["cb_data"]) ? $options["cb_data"] : null;
         $watcher->isEnabled = isset($options["enable"]) ? (bool) $options["enable"] : true;
         $watcher->keepAlive = isset($options["keep_alive"]) ? (bool) $options["keep_alive"] : true;
         $watcher->msInterval = round(($msInterval / 1000), 3);
@@ -424,7 +424,7 @@ private function registerIoWatcher($stream, $callback, $options, $type) {
         $watcher->id = $watcherId = \spl_object_hash($watcher);
         $watcher->type = $type;
         $watcher->callback = $callback;
-        $watcher->cbData = @$options["cb_data"];
+        $watcher->cbData = isset($options["cb_data"]) ? $options["cb_data"] : null;
         $watcher->isEnabled = isset($options["enable"]) ? (bool) $options["enable"] : true;
         $watcher->keepAlive = isset($options["keep_alive"]) ? (bool) $options["keep_alive"] : true;
         $watcher->stream = $stream;