Why do we have Amp\Future

[kelunik]

What's the purpose of Amp\Future? It's documented to be used only in internal code, no public APIs?

[bwoebi]

Amp\Future is meant to be used inside libraries, i.e. it never should cross public API boundaries, correct.

[kelunik]

Why do we have it now? Why not just Deferred as we had previously?

[bwoebi]

I'm not 100% sure why it's necessary. The only difference is it saving us from a single ->getAwaitable() call. I do not think this is worth it…

But perhaps I'm missing something and @trowski can tell.

[kelunik]

That's exactly why this issue exists.

[trowski]

Future (and Producer for observables) only exists to avoid the function call to retrieve the awaitable (or observable) when the object will never be exposed to a public API. It's a minor performance bump, but if the confusion isn't worth it, Deferred and Postponed can be used instead.

[kelunik]

We didn't need it in Amp v1, I don't think we need it in Amp v2. It adds more confusion than a single method call can save us.

[bwoebi]

Resolved by removal.