Add v1 #35
Open
Add v1 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iggyvolz
commented
Dec 15, 2021
| */ | ||
| public function testReserve($reserveTimeout, $connectionCloseTimeout, $testFailTimeout) { | ||
| public function testReserve(?int $reserveTimeout, int $connectionCloseTimeout, int $testFailTimeout): void { |
There was a problem hiding this comment.
For some reason this is always failing on the first invocation with no exception thrown, but passing (i.e. throwing correctly) on the second invocation
|
@iggyvolz Thank you for your work! We'll eventually get to this package, we're currently tagging beta versions for all the lower level libraries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies to Amp v3 similar to amphp/http-client-psr7#4 - don't have it working yet because I'm getting some fiber errors that I haven't been able to debug trying to run the examples:
Seems to be related to the
$deferred->getFuture()->await();call inBeanstalkClient::send()but I can't figure out for the life of me what I'm doing wrong there.