stream_socket_shutdown resources in ROS on close

amphp · Jun 18, 2017 · 161c734 · kelunik · Jun 18, 2017 · 161c734
1 parent cc42b43
commit 161c734
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/lib/ResourceOutputStream.php b/lib/ResourceOutputStream.php
@@ -206,6 +206,10 @@ private function send(string $data, bool $end = false): Promise {
      * @return void
      */
     public function close() {
+        if ($this->resource) {
+            \stream_socket_shutdown($this->resource, \STREAM_SHUT_WR);
+        }
+
         $this->resource = null;
         $this->writable = false;
 

diff --git a/test/ResourceStreamTest.php b/test/ResourceStreamTest.php
@@ -17,17 +17,9 @@ public function testLargePayloads() {
             $b = new ResourceInputStream($right);
 
             $length = 1 * 1024 * 1024; // 1M
+            $message = \str_repeat(".", $length);
 
-            $message = "";
-            for ($i = 0; $i < $length; $i++) {
-                $message .= \chr(\mt_rand(33, 125));
-            }
-
-            $a->end($message)->onResolve(function () use (&$a, &$left) {
-                // Let GC close resource
-                $a = null;
-                $left = null;
-            });
+            $a->end($message);
 
             $received = "";
             while (null !== $chunk = yield $b->read()) {