Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check whether IP version is right on resolve #51

Closed
kelunik opened this issue Feb 5, 2017 · 1 comment
Closed

Missing check whether IP version is right on resolve #51

kelunik opened this issue Feb 5, 2017 · 1 comment
Labels

Comments

@kelunik
Copy link
Member

kelunik commented Feb 5, 2017

Calling resolve with an IP address currently simply resolves to chat address. But it doesn't check whether it's allowed by the current "types" in $options:

var_dump(yield Amp\Dns\resolve('8.8.8.8', ['types' => Amp\Dns\Record::AAAA])); works just fine, but should result in an exception, because no records found. Or for the AAAAA case, we can rewrite it to an IPv6 address.

@kelunik kelunik added the bug label Feb 5, 2017
@kelunik
Copy link
Member Author

kelunik commented Jun 23, 2017

This will be resolved in the Amp v2 version.

@kelunik kelunik closed this as completed Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant