Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make amphp/windows-registry a suggested dependency #63

Closed
shouze opened this issue Aug 16, 2017 · 4 comments
Closed

Make amphp/windows-registry a suggested dependency #63

shouze opened this issue Aug 16, 2017 · 4 comments

Comments

@shouze
Copy link

shouze commented Aug 16, 2017

As it's platform related and make vendor dir heavier for nothing when not running code on Windows.

@kelunik
Copy link
Member

kelunik commented Aug 16, 2017

That would make any app and library incompatible with Windows by default, so I'm against that.

@shouze
Copy link
Author

shouze commented Aug 16, 2017

not incompatible by default as it's suggested & have to be documented but I understand your argument of course.

@shouze
Copy link
Author

shouze commented Aug 16, 2017

The point is composer don't permit ATM to express requirements that vary depending on OS or php version, which would be great & make a more decent solution of course.

@kelunik
Copy link
Member

kelunik commented Aug 16, 2017

Right, this is an issue Composer needs to solve first. suggest is completely broken as it doesn't allow any constraints. Yes, you can achieve that with conflicts, but it's really sub-optimal.

I very much prefer a little bit of space in favor of compatible by default.

@kelunik kelunik closed this as completed Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants