Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache DNS records based on the record requested #56

Closed
wants to merge 1 commit into from
Closed

Cache DNS records based on the record requested #56

wants to merge 1 commit into from

Commits on May 26, 2017

  1. Cache DNS records based on the record requested 

    Currently Amp/DNS will only cache (in-memory) for the record type returned from
the DNS server. that means if we look up a DNAME record and instead receive a
CNAME record, it'll be cached under CNAME, leading amp to make additional
requests for the DNAME record it technically already received.

This commit changes this behavior and instead caches the record with the
requested type as the key rather than the returned type.
    Peleg Rosenthal committed May 26, 2017
    Copy the full SHA
    2b7557c View commit details
    Browse the repository at this point in the history