Fix Windows build #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a super hacky solution, but should work for any shared builds. First we need to fix the obj filenames, since these are expected in the src/ subfolder. To trigger their compilation, we write the required dependency rules manually to the Makefile. Finally we add the assembler obj files as LD_FLAGS. A clean solution would be to support asm files as source files in the Windows build chain. If that does not happen, at least we should use a Makefile.fragment, to avoid the dependency on `MFO`. We also should strive to minimize the use of global variables in config.w32.
trowski
force-pushed
the
windows
branch
3 times, most recently
from
f056234
to
459d93d
Compare
|
Manually merged, thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super hacky solution, but should work for any shared builds.
First we need to fix the obj filenames, since these are expected in the
src/ subfolder. To trigger their compilation, we write the required
dependency rules manually to the Makefile. Finally we add the assembler
obj files as LD_FLAGS.
A clean solution would be to support asm files as source files in the
Windows build chain. If that does not happen, at least we should use
a Makefile.fragment, to avoid the dependency on
MFO. We also shouldstrive to minimize the use of global variables in config.w32.