Skip tests causing segfaults on older PHP versions

amphp · May 9, 2020 · 3afd78b · 3afd78b
1 parent 16ed360
commit 3afd78b
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 5 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,5 +1,5 @@
-sudo: false
-
+dist: xenial
+os: linux
 language: php
 
 php:
@@ -8,7 +8,7 @@ php:
   - 7.4
   - nightly
 
-matrix:
+jobs:
   allow_failures:
     - php: nightly
   fast_finish: true
@@ -27,8 +27,8 @@ install:
       composer update -n --prefer-dist;
     fi
 
-  - wget https://github.com/php-coveralls/php-coveralls/releases/download/v2.1.0/php-coveralls.phar
-  - wget https://github.com/maglnet/ComposerRequireChecker/releases/download/2.0.0/composer-require-checker.phar
+  - wget https://github.com/php-coveralls/php-coveralls/releases/download/v2.2.0/php-coveralls.phar
+  - wget https://github.com/maglnet/ComposerRequireChecker/releases/download/2.1.0/composer-require-checker.phar
 
   - composer show
   - cd test/tls && ./regenerate.sh && cd -

diff --git a/test/Connection/Http2ConnectionTest.php b/test/Connection/Http2ConnectionTest.php
@@ -174,6 +174,10 @@ public function testTrailersWithoutTrailers(): \Generator
 
     public function testCancellingWhileStreamingBody(): \Generator
     {
+        if (\PHP_VERSION_ID < 70400) {
+            $this->markTestSkipped('Causes segfaults on PHP < 7.4');
+        }
+
         $hpack = new HPack;
 
         [$server, $client] = Socket\createPair();
@@ -224,6 +228,10 @@ public function testCancellingWhileStreamingBody(): \Generator
 
     public function testTimeoutWhileStreamingBody(): \Generator
     {
+        if (\PHP_VERSION_ID < 70400) {
+            $this->markTestSkipped('Causes segfaults on PHP < 7.4');
+        }
+
         $hpack = new HPack;
 
         [$server, $client] = Socket\createPair();
@@ -275,6 +283,10 @@ public function testTimeoutWhileStreamingBody(): \Generator
 
     public function testCancellingPushPromiseBody(): \Generator
     {
+        if (\PHP_VERSION_ID < 70400) {
+            $this->markTestSkipped('Causes segfaults on PHP < 7.4');
+        }
+
         $hpack = new HPack;
 
         [$server, $client] = Socket\createPair();
@@ -349,6 +361,10 @@ public function testCancellingPushPromiseBody(): \Generator
 
     public function testInactivityWhileStreamingBody(): \Generator
     {
+        if (\PHP_VERSION_ID < 70400) {
+            $this->markTestSkipped('Causes segfaults on PHP < 7.4');
+        }
+
         $hpack = new HPack;
 
         [$server, $client] = Socket\createPair();

diff --git a/test/Connection/StreamLimitingPoolTest.php b/test/Connection/StreamLimitingPoolTest.php
@@ -11,6 +11,10 @@ class StreamLimitingPoolTest extends AsyncTestCase
 {
     public function testByHost(): \Generator
     {
+        if (\PHP_VERSION_ID < 70400) {
+            $this->markTestSkipped('Causes segfaults on PHP < 7.4');
+        }
+
         $client = (new HttpClientBuilder)
             ->usingPool(StreamLimitingPool::byHost(new UnlimitedConnectionPool, new LocalKeyedMutex))
             ->build();