Immutable client #199
Merged
Immutable client #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trowski
force-pushed
the
immutable-client
branch
from
eaa9265
to
342e0b4
Compare
|
👍 Yeah, immutable client would be really nice. I could then have it as a service in my dependency injection container and add additional interceptors as needed without touching the service itself. Ofc I can still do it with cloning but this feels better. |
trowski
force-pushed
the
immutable-client
branch
from
342e0b4
to
211e2b9
Compare
|
Rebasing on master was simple, so I did that quickly. Will need to rebase #198 on this after merging. |
trowski
force-pushed
the
immutable-client
branch
from
211e2b9
to
5759d65
Compare
kelunik
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #198. @kelunik thoughts on the last commit?