Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timing API / HAR support #220

Merged
merged 14 commits into from
Nov 11, 2019
Merged

Add timing API / HAR support #220

merged 14 commits into from
Nov 11, 2019

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Nov 10, 2019

@kelunik kelunik requested a review from trowski November 10, 2019 17:33
@kelunik
Copy link
Member Author

kelunik commented Nov 10, 2019

While looking at the HAR for php examples/basic/6-customization.php https://example.org/ I noticed strange blocking times. Those are caused by the HTTP/2 pings we do for connection liveness. I guess we should remove these pings, as they cause unnecessary delay.

@kelunik kelunik mentioned this pull request Nov 11, 2019
Closed
@kelunik kelunik merged commit d5b9d3a into master Nov 11, 2019
@kelunik kelunik deleted the har branch November 11, 2019 20:58
b922
b922 reviewed Dec 17, 2019
View reviewed changes
Copy link

@b922 b922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trowski trowski trowski left review comments

@b922 b922 b922 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add timing API
3 participants
@kelunik @trowski @b922