Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set used protocol version to request #221

Merged
merged 1 commit into from Nov 11, 2019
Merged

Set used protocol version to request #221

merged 1 commit into from Nov 11, 2019

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Nov 11, 2019

No description provided.

@kelunik kelunik requested a review from trowski November 11, 2019 19:47
@trowski
Copy link
Member

trowski commented Nov 11, 2019

What's the purpose? Response::getProtocolVersion() tells you what protocol version was used.

@kelunik
Copy link
Member Author

kelunik commented Nov 11, 2019

@trowski With HTTP/1.0, you might get a HTTP/1.1 response, no?

@trowski
Copy link
Member

trowski commented Nov 11, 2019

Yes, you might receive a 1.1 response, but how does setting it on the Request object help?

@kelunik
Copy link
Member Author

kelunik commented Nov 11, 2019

@trowski It allow printing the request as sent.

@trowski trowski merged commit 1095a60 into master Nov 11, 2019
@kelunik kelunik deleted the protocol-version branch November 11, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trowski trowski Awaiting requested review from trowski

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kelunik @trowski