Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HttpClientBuilder::with/withoutHeaderIfUnset() #238

Closed
wants to merge 1 commit into from
Closed

Add HttpClientBuilder::with/withoutHeaderIfUnset() #238

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Contributor

Useful when we want to disable the default interceptors, as in symfony/symfony#35115 (review)

@nicolas-grekas nicolas-grekas mentioned this pull request Dec 31, 2019
Merged
21 tasks
kelunik
kelunik reviewed Dec 31, 2019
View reviewed changes
Copy link
Member

@kelunik kelunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be separate functions to opt-out of any of these, just like you have to disable retries or redirect following separately.

@nicolas-grekas nicolas-grekas changed the title Add HttpClientBuilder::withoutDefaultInterceptors() Add HttpClientBuilder::with/withoutHeaderIfUnset() Jan 1, 2020
@nicolas-grekas
Copy link
Contributor Author

I think these should be separate functions to opt-out of any of these

updated

kelunik added a commit that referenced this pull request Jan 1, 2020
@kelunik @nicolas-grekas
Allow skipping the default interceptors in HttpClientBuilder
ba05afb 
Closes #238.

Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
@kelunik kelunik mentioned this pull request Jan 1, 2020
Merged
@kelunik
Copy link
Member

kelunik commented Jan 1, 2020

I've implemented it slightly differently in #241, what do you think?

@nicolas-grekas
Copy link
Contributor Author

Works for me thanks!

trowski pushed a commit that referenced this pull request Jan 14, 2020
@kelunik @nicolas-grekas @trowski
Allow skipping the default interceptors in HttpClientBuilder
a74fde7 
Closes #238.

Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolas-grekas @kelunik