Error if request URI provides relative path #269
Conversation
|
The build is failing but it seems to have been failing for some time. Tests are segfaulting for some reason under 7.2 even locally (I failed to understand why) but run okay on 7.3 and 7.4. I've re-checked that at least my tests are running okay on all three versions. |
| $uri->method('withPort')->willReturnSelf(); | ||
| $uri->method('withQuery')->willReturnSelf(); | ||
| $uri->method('withFragment')->willReturnSelf(); | ||
| $uri->method('__toString')->willReturn('http://localhost/foo'); |
There was a problem hiding this comment.
Do we need a mock here or can we just use league/uri?
There was a problem hiding this comment.
We need mock because league/uri doesn't allow relative paths and I don't think it's a good idea to require-dev another implementation that does allow them (laminas/laminas-diactoros, for example).
There was a problem hiding this comment.
That's good to know, thanks! I wouldn't have a problem with requiring laminas/laminas-diactoros in require-dev.
There was a problem hiding this comment.
That's not a big problem, but they can decide to change this behavior in future - I think it's better not to rely on it. Anyway, it's just one small negative corner-case.
Co-authored-by: Niklas Keller <me@kelunik.com>
|
If you rebase onto |
Hmm, I need to take a closer look... |
I think it's wise to make checks just before contract protects us; and in our case contract of |
|
Seems that some tests are flaky. |
kelunik
changed the title
|
Thanks! |
No description provided.