Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonContent #355

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Add JsonContent #355

merged 4 commits into from
Dec 15, 2023

Conversation

trowski
Copy link
Member

@trowski trowski commented Dec 10, 2023

Adds a simple JsonContent request body implementation, as sending a JSON body is very common.

@trowski trowski requested a review from kelunik December 10, 2023 18:30
kelunik
kelunik reviewed Dec 10, 2023
View reviewed changes
Copy link
Member

@kelunik kelunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a function reusing a generic implementation under the hood.

@trowski
Copy link
Member Author

trowski commented Dec 14, 2023 •
edited

@kelunik I made it a static method on BufferedContent. Does this seem appropriate or do you think it should be a regular function? If so, do you have a name suggestion? I was thinking createJsonContent.

@trowski trowski merged commit caf8148 into 5.x Dec 15, 2023
10 checks passed
@trowski trowski deleted the json-content branch April 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trowski @kelunik