Fix Session::isRead() / Session::isLocked()

amphp · Sep 27, 2019 · 938e1ff · 938e1ff
1 parent 76eb5f8
commit 938e1ff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/Session.php b/src/Session.php
@@ -67,15 +67,15 @@ public function getId(): ?string
      */
     public function isRead(): bool
     {
-        return $this->status & self::STATUS_READ !== 0;
+        return ($this->status & self::STATUS_READ) !== 0;
     }
 
     /**
      * @return bool `true` if the session has been locked.
      */
     public function isLocked(): bool
     {
-        return $this->status & self::STATUS_LOCKED !== 0;
+        return ($this->status & self::STATUS_LOCKED) !== 0;
     }
 
     /**

diff --git a/test/DriverTest.php b/test/DriverTest.php
@@ -83,8 +83,14 @@ public function testConcurrentLocking(): \Generator
         $sessionA = $driver->create($sessionId);
         $sessionB = $driver->create($sessionId);
 
+        $this->assertFalse($sessionA->isRead());
+        $this->assertFalse($sessionA->isLocked());
+
         yield $sessionA->open();
 
+        $this->assertTrue($sessionA->isRead());
+        $this->assertTrue($sessionA->isLocked());
+
         $this->expectException(TimeoutException::class);
 
         try {