Added data type validation passed to bind method #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Sep 6, 2017
lib/Stmt.php
Outdated
| @@ -86,6 +86,10 @@ public function bind($paramId, $data) { | |||
| $i = reset($array); | |||
| } | |||
|
|
|||
| if (!is_scalar($data) && !(is_object($data) && method_exists($data, '__toString'))) { | |||
| throw new \InvalidArgumentException("Data must be scalar or object that implements __toString method"); | |||
There was a problem hiding this comment.
I think I'd just throw a TypeError here.
kelunik
reviewed
Sep 6, 2017
test/Mysql/StmtTest.php
Outdated
| @@ -0,0 +1,77 @@ | |||
| <?php | |||
| /* | |||
| * This file is part of the OpCart software. | |||
There was a problem hiding this comment.
ops... 😄 This should not be here
dbalabka
force-pushed
the
check-stmt-bind-types
branch
from
f05e5ce
to
cf55e23
Compare
dbalabka
force-pushed
the
check-stmt-bind-types
branch
from
cf55e23
to
79fc5a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for #39