Fix ignored port in getConnectionString()

[bzikarsky]

Quick and obvious bugfix.

[bzikarsky]

It looks like the CI failed because the database sometimes failed to bootstrap. Unrelated to my change.

[staabm]

you should provide a unit test

[bzikarsky]

Possibly, but:

• The repo's unit-tests require a locally available mysqld binary without there being a Dockerfile or similar to run the tests in
• ConnectionConfigTest is not even tested at all in v1.x

If there is test-suite which can both run and changed easily I will gladly provide test cases. In this case, this is too much of a hustle.

[kelunik]

Maybe I'm missing something, but it seems pretty weird to parse the port from the host here at all if we always have a host and a port in the object.

[bzikarsky]

I think the main issue is the API design - having both a dedicated $port property and supporting <host>:<port> syntax on $host. That's redundant. Aynway: Ignoring $port in all varaints of getConnectionString() is just wrong. $port will be initalized to 3360 by default, so the code works the same, if the constructor argument is not used. In case it is, and there is no additional port hidden in $host, this patch will make sure, it is used.

[bzikarsky]

Is there something blocking this PR from my side?

[kelunik]

Nope.

[kelunik]

Thanks!

[bzikarsky]

Thanks for merging - when can we expect a patch-release?