[WIP] Separate connection and client responsibility #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brzuchal
commented
Jun 7, 2019
| @@ -118,6 +150,8 @@ public function send(array $strings): Promise | |||
| yield $this->connect(); | |||
| yield $this->socket->write($payload); | |||
| }); | |||
|
|
|||
| return $deferred->promise(); | |||
There was a problem hiding this comment.
@kelunik tests are passing but I'm not 100% sure if I have changed invoking call and returning Deferred properly. Any advice if it is wrong?
|
I've done a quite bigger change in v1.0.0-rc1, but responsibilities are separate now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is to separate responsibility of proper connecting with
AUTHandSELECTinsideConnectionclass.So the client is responsible for sending commands and transforming a result.
This introduces
ConnectionConfigas well cause we got 3 different URI formats now.