Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer IPv4 over IPv6, fixes #35 #44

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Prefer IPv4 over IPv6, fixes #35 #44

merged 1 commit into from
Oct 31, 2017

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Oct 30, 2017

See #35.

@kelunik kelunik mentioned this pull request Oct 30, 2017
Closed
trowski
trowski reviewed Oct 31, 2017
View reviewed changes
lib/functions.php Outdated
// Usually the faster response should be preferred, but we don't have a reliable way of determining IPv6
// support, so we always prefer IPv4 here.
\usort($records, function (Dns\Record $a, Dns\Record $b) {
return $a === Dns\Record::A ? -1 : 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant $a->getType() instead of just $a I assume?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. 😉

@kelunik kelunik merged commit ef03a72 into master Oct 31, 2017
@kelunik kelunik deleted the ipv6-prefer branch October 31, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trowski trowski trowski left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kelunik @trowski