Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Revolt 0.2 #20

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Update for Revolt 0.2 #20

merged 1 commit into from
Jan 27, 2022

Conversation

iggyvolz
Copy link
Contributor

Not sure if this should be ^0.1 || ^0.2 or just ^0.2. Current state causes a conflict at the moment where amphp/http-client:^5 can't be installed because:

  Problem 1
    - Root composer.json requires amphp/sync ^2 -> satisfiable by amphp/sync[v2.0.0-beta.1, v2.x-dev].
    - amphp/pipeline dev-master requires revolt/event-loop ^0.2 -> satisfiable by revolt/event-loop[v0.2.0].
    - amphp/pipeline 1.x-dev is an alias of amphp/pipeline dev-master and thus requires it to be installed too.
    - You can only install one version of a package, so only one of these can be installed: revolt/event-loop[dev-main, v0.1.1, v0.2.0].
    - amphp/http-server v3.x-dev requires amphp/pipeline v1.x-dev -> satisfiable by amphp/pipeline[1.x-dev (alias of dev-master)].
    - amphp/sync[v2.0.0-beta.1, ..., v2.x-dev] require revolt/event-loop ^0.1 -> satisfiable by revolt/event-loop[v0.1.0, v0.1.1].
    - Root composer.json requires amphp/http-server ^3 -> satisfiable by amphp/http-server[v3.x-dev].

@kelunik
Copy link
Member

kelunik commented Jan 27, 2022

^0.1 || ^0.2 is probably fine for many libs, but the new beta of pipeline will require 0.2 anyway, so we can leave it as ^0.2

Could you please have a look at the signature of your commit? GitHub doesn't seem to recognize it.

@iggyvolz
Copy link
Contributor Author

Could you please have a look at the signature of your commit? GitHub doesn't seem to recognize it.

Oops I was toying with SSH signatures (https://blog.dbrgn.ch/2021/11/16/git-ssh-signatures/) but it looks like GitHub doesn't support them yet (community/community#7744 (comment)). I can re-commit without the signature.

@kelunik kelunik changed the title Update v2 for Revolt 0.2 Update for Revolt 0.2 Jan 27, 2022
@kelunik kelunik merged commit 6703105 into amphp:v2 Jan 27, 2022
@kelunik
Copy link
Member

kelunik commented Jan 27, 2022

@iggyvolz Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants