3/media query debugger #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Byron
commented
Apr 1, 2020
|
|
||
| const MediaQueryDebugger = ( props ) => { | ||
|
|
||
| if (props.isVisible != 'true') return null |
There was a problem hiding this comment.
This was previously process.env.GATSBY_DEBUG_MEDIA_QUERIES !== 'true'. It was replaced to resolve an eslint error that was blocking the build pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Notes
When locally linking this component to GIAC using
yarn linkI ran into the following 3 issues ...Running
$ yarn link gatsby-theme-ample-componentsin your target repository after running$ yarn linkcreates a symbolic link innode_modulesthat overwrites thegatsby-theme-ample-componentstheme directory innode_modules, causing webpack to fail it's SSR bundle generator. One solution to this is to change the name of your link inpackage.jsonRunning
$ yarn developwill cause webpack to throw a missing module error in.eslint.rc.jsforeslint-plugin-jest. I was able to work around this by removing jest in.eslint.rc.jsAfter bypassing the previous issue for
$ yarn developI ran into another link issue ...Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons. The solution for this can be found here