Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The properties names of pending changes (Entity/Block) could be confusing due to the new project resource hierarchy #3305

Closed
abrl91 opened this issue Aug 2, 2022 · 1 comment · Fixed by #3306
Closed

The properties names of pending changes (Entity/Block) could be confusing due to the new project resource hierarchy #3305

abrl91 opened this issue Aug 2, 2022 · 1 comment · Fixed by #3306
Assignees
@abrl91
Labels
type: bug Something isn't working
Milestone
0.14.11

Comments

@abrl91
Copy link
Member

abrl91 commented Aug 2, 2022

What happened?

On one of our latest releases, we rename App to Resource.
We also have PendingChanges DTO (Entity/Block) that has 2 properties that could make confusion: resource and resourceId

What you expected to happen

Change the name of those properties

How to reproduce

--

Amplication version

0.14.10

Environment

No response

Are you willing to submit PR?

Yes I am willing to submit a PR!
@abrl91 abrl91 added type: bug Something isn't working @amplication/server labels Aug 2, 2022
@abrl91 abrl91 self-assigned this Aug 2, 2022
@abrl91 abrl91 mentioned this issue Aug 2, 2022
Merged
2 tasks
@abrl91 abrl91 linked a pull request Aug 2, 2022 that will close this issue
Refactor: Pending Changes (Entity/Block) rename resource to origin #3306
Merged
2 tasks
@abrl91 abrl91 added this to the 0.14.11 milestone Aug 2, 2022
@abrl91
Copy link
Member Author

abrl91 commented Aug 3, 2022

Fixed by #3306

@abrl91 abrl91 closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrl91 abrl91

Labels
type: bug Something isn't working
Projects
None yet
Milestone
0.14.11
Development

Successfully merging a pull request may close this issue.

Refactor: Pending Changes (Entity/Block) rename resource to origin amplication/amplication
1 participant
@abrl91