Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Pending Changes (Entity/Block) rename resource to origin #3306

Merged
merged 4 commits into from Aug 3, 2022
Merged

Refactor: Pending Changes (Entity/Block) rename resource to origin #3306

merged 4 commits into from Aug 3, 2022

Conversation

abrl91
Copy link
Member

@abrl91 abrl91 commented Aug 2, 2022 •
edited

Issue Number: #3305

PR Details

rename:

  • resource => origin
  • resourceId => originId
  • resourceType => originType
  • EnumPendingChangeResourceType => EnumPendingChangeOriginType
  • InjectableResourceParameter => InjectableOriginParameter

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

@abrl91 abrl91 requested a review from yuval-hazaz August 2, 2022 19:11
@abrl91 abrl91 self-assigned this Aug 2, 2022
@abrl91 abrl91 changed the title Refactor: Pending Changes (Entity/Block) rename resource/resourceId to origin/originId re Refactor: Pending Changes (Entity/Block) rename resource to origin Aug 2, 2022
@abrl91 abrl91 linked an issue Aug 2, 2022 that may be closed by this pull request
The properties names of pending changes (Entity/Block) could be confusing due to the new project resource hierarchy #3305
Closed
@abrl91 abrl91 added the 0.14.11 label Aug 2, 2022
@abrl91 abrl91 marked this pull request as draft August 2, 2022 19:43
@abrl91 abrl91 changed the base branch from master to release/0.14.11 August 2, 2022 20:58
@abrl91 abrl91 marked this pull request as ready for review August 2, 2022 21:01
@yuval-hazaz yuval-hazaz merged commit ab9e209 into release/0.14.11 Aug 3, 2022
@yuval-hazaz yuval-hazaz deleted the refactor/3305-rename-pending-changes-properties branch August 3, 2022 09:07
@tupe12334 tupe12334 restored the refactor/3305-rename-pending-changes-properties branch August 3, 2022 12:19
@tupe12334 tupe12334 deleted the refactor/3305-rename-pending-changes-properties branch August 3, 2022 12:51
This was referenced Aug 3, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuval-hazaz yuval-hazaz yuval-hazaz approved these changes

Assignees

@abrl91 abrl91

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abrl91 @yuval-hazaz