Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): profile button doesn't lead to anywhere #2318

Merged

Conversation

molaycule
Copy link
Contributor

Issue Number: #2307

PR Details

This pull request solves the issue when profile button is click and nothing happens. On click of the profile button, user is taken to a profile page.

@yuval-hazaz
Copy link
Member

Thanks @molaycule
This looks great!
I will review the code soon

@yuval-hazaz yuval-hazaz linked an issue Feb 19, 2022 that may be closed by this pull request
@yuval-hazaz yuval-hazaz self-requested a review February 19, 2022 07:27
@yuval-hazaz yuval-hazaz changed the base branch from master to feat/profile-page February 19, 2022 07:30
Copy link
Member

@yuval-hazaz yuval-hazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work

@yuval-hazaz yuval-hazaz merged commit 0598a24 into amplication:feat/profile-page Feb 19, 2022
@yuval-hazaz yuval-hazaz mentioned this pull request Feb 19, 2022
2 tasks
@yuval-hazaz
Copy link
Member

@all-contributors please add @molaycule for code and bug fixes

@allcontributors
Copy link
Contributor

@yuval-hazaz

I've put up a pull request to add @molaycule! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Profile button doesn't lead to anywhere
2 participants