Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Change colors #2443

Merged
merged 3 commits into from
Mar 22, 2022
Merged

fix(client): Change colors #2443

merged 3 commits into from
Mar 22, 2022

Conversation

RakeshPotnuru
Copy link
Contributor

Issue Number: #2431

PR Details

Changed background and hover colours for the support menu.

PR Checklist

  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link
Member

@yuval-hazaz yuval-hazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR with Amplication.
Please see my suggestions
Instead of using hardcoded color values, you should be using CSS variables

packages/amplication-client/src/Layout/SupportMenu.scss Outdated Show resolved Hide resolved
packages/amplication-client/src/Layout/SupportMenu.scss Outdated Show resolved Hide resolved
@yuval-hazaz yuval-hazaz changed the base branch from master to release/0.12.2 March 16, 2022 18:30
@yuval-hazaz yuval-hazaz added type: bug Something isn't working type: style Changes that do not affect the meaning of the code (white-space, formatting, missing semi-col labels Mar 16, 2022
RakeshPotnuru and others added 2 commits March 17, 2022 10:09
Co-authored-by: Yuval Hazaz <yuval@amplication.com>
Co-authored-by: Yuval Hazaz <yuval@amplication.com>
@tupe12334
Copy link
Contributor

Approved on staging

@mshidlov mshidlov merged commit eb01f7e into amplication:release/0.12.2 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: style Changes that do not affect the meaning of the code (white-space, formatting, missing semi-col
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: client - help menu background color is not visible on the default page background
4 participants