Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsg admin ui saved changes on m2m relation #2494

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

abrl91
Copy link
Member

@abrl91 abrl91 commented Mar 23, 2022

resolved #2493

the problem was the pluralized utility function.

image

The source attribute of ReferenceArrayInput expect to get an unpluralized version of the entity
(maybe after the change we did on ra-data-graphql-amplication package because I remember that before it didn't work with the unpluralized version)

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

@abrl91 abrl91 requested a review from yuval-hazaz March 23, 2022 07:46
@abrl91 abrl91 self-assigned this Mar 23, 2022
@abrl91 abrl91 added 0.12.0 and removed 0.12.0 labels Mar 23, 2022
@abrl91 abrl91 added this to the 0.12.2 milestone Mar 23, 2022
@mshidlov mshidlov removed this from the 0.12.2 milestone Mar 23, 2022
@mshidlov mshidlov removed the 0.12.2 label Mar 23, 2022
@mshidlov mshidlov changed the base branch from release/0.12.2 to master March 23, 2022 08:07
@mshidlov mshidlov linked an issue Mar 23, 2022 that may be closed by this pull request
@abrl91 abrl91 changed the base branch from master to release/0.12.2 March 23, 2022 08:20
@abrl91 abrl91 added this to the 0.12.2 milestone Mar 23, 2022
@abrl91 abrl91 added the 0.12.2 label Mar 23, 2022
@mshidlov mshidlov removed this from the 0.12.2 milestone Mar 23, 2022
@mshidlov mshidlov merged commit a09b67c into release/0.12.2 Mar 23, 2022
@mshidlov mshidlov deleted the fix/2493-react-adminui-unsaved-changes branch March 23, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: React admin-ui m2m unsaved changes
3 participants