Fix/2423 info popup state always open

[salindae25]

Issue Number: #2423

PR Details

1. Remove open={supportMenuOpen} from the Popover element. ( this will allow it to have default behavior)
2. Added onOpen={handleSupportClick} to the Popover element. ( this will make sure to fire the trackEvent)
3. Removed all supportMenuOpen state related references.

PR Checklist

• Tests for the changes have been added
• npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

[yuval-hazaz]

@salindae25 congrats for your first contribution with Amplication
Great work

[muhsinkamil]

@salindae25 Can we remove onClick at MenuItem on line 110

[salindae25]

@salindae25 Can we remove onClick at MenuItem on line 110

yes, it does not affect the functionality of the popover menu.

[muhsinkamil]

yes, it does not affect the functionality of the popover menu.

@salindae25
I see, can you please remove that.

The reason is, trackEvent is fired twice when the icon is clicked.
First onOpen -> opens tooltip and fires trackEvent
second onClick -> does nothing ( since open already ) and fires trackEvent

cc: @yuval-hazaz

[salindae25]

yes, it does not affect the functionality of the popover menu.

@salindae25 I see, can you please remove that.

The reason is, trackEvent is fired twice when the icon is clicked. First onOpen -> opens tooltip and fires trackEvent second onClick -> does nothing ( since open already ) and fires trackEvent

cc: @yuval-hazaz

sure i'll remove the click event