fix(dsg): [BREAKING CHANGE] duplicated modules #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 758ff50. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
1 task
This was
linked to
issues
Apr 21, 2023
2 tasks
overbit
force-pushed
the
fix/duplicated-modules
branch
3 times, most recently
from
5991965
to
d49c8e3
Compare
overbit
changed the title
overbit
force-pushed
the
fix/duplicated-modules
branch
2 times, most recently
from
b648286
to
6ec8ce9
Compare
abrl91
reviewed
Apr 28, 2023
overbit
force-pushed
the
fix/duplicated-modules
branch
from
9263a4e
to
5e2e593
Compare
Co-authored-by: Amit Barletz <amit@amplication.com>
overbit
force-pushed
the
fix/duplicated-modules
branch
from
5e2e593
to
7828411
Compare
overbit
commented
May 17, 2023
# Conflicts: # packages/data-service-generator/src/utils/read-static-modules.ts
yuval-hazaz
requested changes
May 22, 2023
…ing complexity from O(n*m) to O(n+m)
overbit
force-pushed
the
fix/duplicated-modules
branch
from
7d05313
to
a4e50ef
Compare
overbit
force-pushed
the
fix/duplicated-modules
branch
from
a4e50ef
to
758ff50
Compare
mulygottlieb
approved these changes
May 30, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #5791 #5837
PR Details
In order to fix the duplicated modules in the modules lists, this PR brings a breaking change to the way we interact with file generation by updating the type to a map type
This makes it clear to the developer if a file is going to be overwritten or not and it will allow dsg to always write one file only one time during a single run.
As part of this PR, I've published
@amplication/code-gen-types@2.0.0withbetatag. Once released we need to just retag this version withlatesttag.PR Checklist
npm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.