Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(client): refactor bitbucket lock tooltip text #6032

Merged
merged 6 commits into from
May 18, 2023

Conversation

abrl91
Copy link
Member

@abrl91 abrl91 commented May 17, 2023

Close: #5995

PR Details

  • design system - add new component to limit notfication to handle contact us for enterprise
  • client - use the new component to open the link in a new tab and without concatinate the link to the window location that the use came from (amplication wizard or git sync page)
Screen.Recording.2023-05-17.at.18.40.23.mov

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@abrl91 abrl91 self-assigned this May 17, 2023
@abrl91 abrl91 changed the title Refactor/5995 refactor bitbucket lock tooltip text Refactor(client): refactor bitbucket lock tooltip text May 17, 2023
@abrl91 abrl91 linked an issue May 17, 2023 that may be closed by this pull request
@alexbass86
Copy link
Contributor

Please make sure that the overall padding is exactly like it's in the Figma design.
padding: 6px 8px 6px 6px;

@nx-cloud
Copy link

nx-cloud bot commented May 17, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ec87941. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@abrl91
Copy link
Member Author

abrl91 commented May 17, 2023

Please make sure that the overall padding is exactly like it's in the Figma design. padding: 6px 8px 6px 6px;

I just changed the text and the link that it opens and the way it opens the link :)
UI issues are for the community 😜

@abrl91 abrl91 requested a review from barshimi May 18, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As PO - I want to improve the Bitbucket notification text
3 participants