Refactor(client): UX of create public-private repo #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7d98582. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
barshimi
approved these changes
May 18, 2023
| @@ -4,5 +4,5 @@ export const CreateGitFormSchema = object().shape({ | |||
| name: string() | |||
| .min(2, "Git repository name require minimum of 2 characters") | |||
| .required("Repository name is missing"), | |||
| isPrivate: bool().required("Must select if repo is private"), | |||
| isPublic: bool().required("Must select if repo is private"), | |||
| }); | |||
There was a problem hiding this comment.
"Must select if repo is public" (low priority change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #5994
PR Details
isPublicfor the client and set it totrue, so the toggle will be checked by defaultPR Checklist
npm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.