Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Entity field custom attribute UI #6066

Conversation

yuval-hazaz
Copy link
Member

@yuval-hazaz yuval-hazaz commented May 20, 2023

Part of: #5989

PR Details

The forth PR for the epic - add the client-side functionality for EntityField.CustomAttrbute

🤖 Generated by Copilot at 3274ee3

Summary

🏷️🛠️🆕

This pull request adds support for custom attributes for entity fields, which are additional properties that users can define for their fields in the entity editor. It modifies several GraphQL queries and mutations, as well as React components, to include and display the customAttributes field. It also fixes a minor issue with the OptionSet component.

To make fields more flexible and smart
We added customAttributes part
To queries and mutations
And some UI creations
And fixed a bug with the Button's art

Walkthrough

  • Add the customAttributes field to various GraphQL queries and mutations to support the new feature of custom attributes for entity fields (link, link, link, link, link, link, link, link, link, link)
  • Add the TextField component to render the customAttributes field in the EntityFieldForm component, which is used to create or edit an entity field (link, link, link, link)
  • Remove the onKeyDown function and prop from the Form component, which were used to prevent the default behavior of submitting the form when the user presses the enter key, and rely on the default behavior of the Form component instead (link, link)
  • Add the type prop to the Button component, which is used to render an option in the OptionSet component, which is used to create or edit an option set field, and set it to "button" to prevent the default behavior of submitting the form when the button is clicked (link)

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@yuval-hazaz yuval-hazaz changed the base branch from master to feat/entity-field-custom-attribute May 20, 2023 08:00
@nx-cloud
Copy link

nx-cloud bot commented May 20, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e166988. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@EugeneTseitlin EugeneTseitlin linked an issue May 20, 2023 that may be closed by this pull request
Base automatically changed from feat/entity-field-custom-attribute to feat/entity-custom-attributes-umbrella May 20, 2023 19:47
@yuval-hazaz yuval-hazaz merged commit 2ef0f28 into feat/entity-custom-attributes-umbrella May 20, 2023
8 checks passed
@yuval-hazaz yuval-hazaz deleted the feat/entity-field-custom-attribute-ui branch May 20, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As User - I want to set custom attributes on the entity level
2 participants