-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/5246-change-log-level-for-business-logs #6067
Merged
mulygottlieb
merged 9 commits into
next
from
fix/5246-change-log-level-for-business-logs
May 22, 2023
Merged
Fix/5246-change-log-level-for-business-logs #6067
mulygottlieb
merged 9 commits into
next
from
fix/5246-change-log-level-for-business-logs
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add copilot PR to our PR template
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3f7ee83. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
morhag90
reviewed
May 21, 2023
2 tasks
mulygottlieb
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #5246
PR Details
🤖 Generated by Copilot at 8f4e49f
Summary
🧪📝🚧
Improved the billing service to handle subscription plan limitations more gracefully. Added a test case and logging for the validation of plan features. Removed validation errors that could block the code generation process in
billing.service.ts
.Walkthrough
BillingFeature
enum and entitlement types from@stigg/node-server-sdk
to use in test case and service methods (link)logger
variable to hold an instance ofAmplicationLogger
for logging purposes (link, link)validateSubscriptionPlanLimitationsForWorkspace
method when workspace has no entitlement to bypass code generation limitation (link)ValidationError
import frombilling.service.ts
as it is no longer used to throw errors (link)throw new ValidationError
statements withlogger.info
calls invalidateSubscriptionPlanLimitationsForWorkspace
method to log limitation errors instead of stopping code generation process (link, link, link, link)PR Checklist
npm test
doesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.