Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): subscription notifications #6125

Merged
merged 1 commit into from
May 29, 2023
Merged

fix(client): subscription notifications #6125

merged 1 commit into from
May 29, 2023

Conversation

yuval-hazaz
Copy link
Member

@yuval-hazaz yuval-hazaz commented May 28, 2023

Close: https://github.com/amplication/private-issues/issues/13

PR Details

πŸ€– Generated by Copilot at eecd210

Summary

πŸ—‘οΈπŸ§ΉπŸ”„

Removed subscription plan code and simplified limitation notification logic in EntityList.tsx and ResourceList.tsx. These changes use the stigg context to handle user entitlements for entities and resources.

The subscription plan code was a mess
So they removed it and made it less
They used stigg context
To handle the next
Limitation notification process

Walkthrough

  • Remove subscription plan logic from entity list and resource list components (link, link)
  • Simplify condition for showing limitation notification to only check hideNotifications entitlement (link, link)

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@yuval-hazaz yuval-hazaz changed the base branch from master to next May 28, 2023 16:34
@nx-cloud
Copy link

nx-cloud bot commented May 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eecd210. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 5 targets

Sent with πŸ’Œ from NxCloud.

@yuval-hazaz yuval-hazaz changed the title Fix/sub notification fix(client): subscription notifications May 28, 2023
@abrl91 abrl91 merged commit 9862b51 into next May 29, 2023
11 checks passed
@abrl91 abrl91 deleted the fix/sub-notification branch May 29, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants