Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dsg): imports issues at runtime #6140

Merged
merged 1 commit into from
May 30, 2023
Merged

fix(dsg): imports issues at runtime #6140

merged 1 commit into from
May 30, 2023

Conversation

overbit
Copy link
Contributor

@overbit overbit commented May 30, 2023

Related: #5837

PR Details

🤖 Generated by Copilot at e115cb5

Summary

🏷️📁🔀

Moved and updated the plugin-events-params.ts file to a new folder and used import type for type-only imports in code-gen-types.ts. This enhances the code structure and performance of the code generation types package.

Sing, O Muse, of the skillful code review
That refined the imports of namedTypes
And made them clear to the discerning eye
As type annotations, not runtime values.

Walkthrough

  • Move plugin-events-params.ts to src/code-gen-types folder and use import type syntax for namedTypes, Generator, and DataSource (link, link)
  • Change import to import type for namedTypes in code-gen-types.ts (link)

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@overbit overbit marked this pull request as ready for review May 30, 2023 09:36
@nx-cloud
Copy link

nx-cloud bot commented May 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e115cb5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx e2e data-service-generator --prod
✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@overbit overbit merged commit 71ec541 into next May 30, 2023
10 of 11 checks passed
@overbit overbit deleted the fix/dsg-runtime branch May 30, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants