Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dsg): add moduleNameMapper to the jest configuration of the server #7411

Merged

Conversation

77629296
Copy link
Contributor

@77629296 77629296 commented Nov 13, 2023

Close: #5924 #7048

PR Details

before:
image

after:
image
image

πŸ€– Generated by Copilot at 91521c5

Summary

πŸ”§πŸ”βœ…

Add Jest module mapping for custom validators in data service generator. This enables testing the validation logic for the generated data models.

Jest needs a mapping
To find @app modules
Autumn of testing

Walkthrough

  • Add custom validation support to the data service generator (- - - - - - - - - - - - - - - - F0

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented Nov 15, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 91521c5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


πŸŸ₯ Failed Commands
nx affected --target=test --coverage --maxWorkers=2
βœ… Successfully ran 3 targets

Sent with πŸ’Œ from NxCloud.

@77629296 77629296 requested a review from a team as a code owner November 15, 2023 14:03
@77629296 77629296 requested a review from barshimi March 17, 2024 14:29
@yuval-hazaz
Copy link
Member

@overbit can you please review this one?

@yuval-hazaz yuval-hazaz requested review from overbit and removed request for barshimi May 25, 2024 16:50
@overbit
Copy link
Contributor

overbit commented May 29, 2024

@77629296 can you please update the snapshots of the snapshot testing?

npx nx affected --target update-snapshot

Copy link

nx-cloud bot commented Jun 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e40fcee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 1 target

Sent with πŸ’Œ from NxCloud.

@overbit
Copy link
Contributor

overbit commented Jun 11, 2024

@mulygottlieb this would need your approval

@overbit overbit merged commit 455cd9d into amplication:next Jun 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› Bug Report: error on tests generated code src/user/base/user.controller.base.spec.ts
5 participants