feat(client+server): Custom Actions feature flag #8110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app:local-data-service-generator-controller
lib:amplication-code-gen-types
lib:ui-design-system
lib:schema-registry
lib:amplication-prisma-db
lib:util-code-gen-utils
lib:util-nestjs-logging
lib:util-nestjs-tracing
lib:util-nestjs-kafka
lib:util-logging
lib:util-git
lib:util-kafka
lib:util-json
app:data-service-generator-catalog
app:data-service-generator
app:notification-service
app:git-sync-manager
app:gpt-gateway
app:amplication-git-push-webhook-service
app:amplication-git-pull-request-service
app:amplication-git-pull-service
app:amplication-storage-gateway
app:amplication-build-manager
app:amplication-client
app:amplication-server
app:amplication-plugin-api
labels
yuval-hazaz
removed
lib:util-kafka
lib:util-json
app:data-service-generator-catalog
app:data-service-generator
app:notification-service
app:git-sync-manager
app:gpt-gateway
app:amplication-git-push-webhook-service
app:amplication-git-pull-request-service
app:amplication-git-pull-service
app:amplication-storage-gateway
app:amplication-build-manager
app:amplication-plugin-api
lib:util-dsg-utils
lib:billing-types
lib:graphql-error-codes
app:gpt-gateway-admin
labels
yuval-hazaz
changed the title
| @@ -16,3 +16,5 @@ NX_REACT_APP_BILLING_API_KEY="$2b$10$kvZ2zkq7onj/oyxH4vZLKuO1P3E9QKuRmo9z72pzggR | |||
| # NX_REACT_APP_GITHUB_CONTROLLER_LOGIN_URL="http://localhost:3000/github" | |||
| NX_REACT_APP_AUTH_LOGIN_URI="http://localhost:3000/auth/login" | |||
| NX_REACT_APP_AUTH_LOGOUT_URI="http://localhost:3000/auth/logout" | |||
|
|
|||
| NX_REACT_APP_FEATURE_CUSTOM_ACTIONS_ENABLED=false | |||
There was a problem hiding this comment.
I'm putting a comment here for myself; we need to add it to the cluster config. It will allow us to run it in Sandbox if we want to.
| @@ -74,3 +74,5 @@ AUTH_ISSUER_CLIENT_DB_CONNECTION=[issuer-client-db-connection] | |||
|
|
|||
| USER_LAST_ACTIVE_DAYS="30" | |||
| CRON_SECRET_KEY=[cron-secret-key] | |||
|
|
|||
| FEATURE_CUSTOM_ACTIONS_ENABLED=false | |||
mulygottlieb
approved these changes
Feb 23, 2024
|
@morhag90 please make sure to go over this PR. I approved it already, but I want you to be familiar as well. This will allow us to merge the custom-actions branch to next (thanks @yuval-hazaz!!!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7713
PR Details
Add aמ env variable to disable Custom Actions features so we can push the main branch into Next without blocking releases until the feature is ready
PR Checklist
npm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.