feat(server):add module functions for assistant service #8342
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dae8f5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
packages/amplication-server/src/core/assistant/assistant.service.ts
Outdated
Show resolved
Hide resolved
| @@ -227,7 +228,7 @@ export class ModuleDtoService extends BlockTypeService< | |||
| ...args, | |||
| data: { | |||
| ...args.data, | |||
| properties: [], | |||
| properties: (args.properties as unknown as JsonArray) ?? [], | |||
There was a problem hiding this comment.
Type casting should be avoided in typescript projects
There was a problem hiding this comment.
that is true.
the BlockCreateInput uses a specific implementation of [key: string]: JsonValue; which causes a type conflict here.
If you think you have a quick workaround, please suggest one, otherwise it will not make sense to make a big change to fix it now
There was a problem hiding this comment.
@overbit please note that because of the [key: string]: JsonValue; BlockCreateInput anyway accepts all types, and the type validation is done on the previous layer per specific block type
…ion/amplication into style/dto-properties-ux
feat(server):create action with jovu
feat(server):add support to get a list of actions in the assistant
style(client):DTO property list UX
feast(server):jovu create enum
Close: #8306
PR Details
PR Checklist
npm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.