chore(code-gen-types): deprecate the old module and modulemap in favour of IFile and FileMap #8355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app:local-data-service-generator-controller
lib:amplication-code-gen-types
lib:schema-registry
app:data-service-generator-catalog
app:data-service-generator
app:notification-service
app:git-sync-manager
app:gpt-gateway
app:amplication-storage-gateway
app:amplication-build-manager
app:amplication-client
app:amplication-server
lib:util-dsg-utils
labels
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ab43d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
overbit
force-pushed
the
refactor/module-map
branch
from
0ff22e0
to
ec09b69
Compare
… ifile and filemap
morhag90
approved these changes
May 1, 2024
overbit
force-pushed
the
refactor/module-map
branch
2 times, most recently
from
a481ca6
to
17d2837
Compare
overbit
force-pushed
the
refactor/module-map
branch
from
17d2837
to
6e2721c
Compare
overbit
force-pushed
the
refactor/module-map
branch
from
3e02550
to
8ab43d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #8353
PR Details
This PR adds a set of new types, called
IFileandFileMapmeant to replace the (deprecated)ModuleandModuleMapto allow a more flexible and extendible implementation of code generators.PR Checklist
npm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.