Test(Server): Test assistant service #8365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f52db31. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
overbit
reviewed
May 2, 2024
packages/amplication-server/src/core/assistant/assistant.service.spec.ts
Outdated
Show resolved
Hide resolved
overbit
reviewed
May 2, 2024
| expect(service).toBeDefined(); | ||
| }); | ||
|
|
||
| it("should throw an AmplicationError if AI-powered features are disabled for the workspace", async () => { |
There was a problem hiding this comment.
Tests looks really good. I'd suggest to add an additional test to cover our expectation on errors from the openai sdk exception
i.e.
should throw an AmplicationError if unexpected issues are returned from the Ai integration
overbit
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #8307
PR Details
PR Checklist
npm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.