Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client):improve chat ux #8391

Merged
merged 2 commits into from May 5, 2024
Merged

feat(client):improve chat ux #8391

merged 2 commits into from May 5, 2024

Conversation

yuval-hazaz
Copy link
Member

@yuval-hazaz yuval-hazaz commented May 4, 2024

Close: #8390

PR Details

  • Allow the user to use enter to submit the message while using shift + enter for a new line
  • expand the height of the text input when writing a multi-line message
  • Enable the text input even when the button is disabled (chat is processing) - to allow the use to start writing the next message without waiting for the end of the response (do not allow submit)

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented May 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0f11ead. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@yuval-hazaz
Copy link
Member Author

@mulygottlieb @overbit I added to this PR a new package to work with hotkeys
The package we currently use is not being maintained for several years already and the new package brings more capabilities that we needed.

I didn't do it as part of this PR, but we should sometime replace the old package with the new packages and remove the old one

https://npmtrends.com/react-hotkeys-vs-react-hotkeys-hook

@yuval-hazaz yuval-hazaz linked an issue May 4, 2024 that may be closed by this pull request
Base automatically changed from feat/jovu-create-entity-fields to next May 5, 2024 09:10
@mulygottlieb mulygottlieb merged commit 1ca51ff into next May 5, 2024
13 checks passed
@mulygottlieb mulygottlieb deleted the feat/jovu-chat-ux branch May 5, 2024 09:11
@overbit overbit mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment