Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/jovu create serviec with plugins #8473

Merged
merged 5 commits into from
May 13, 2024

Conversation

yuval-hazaz
Copy link
Member

Close: #8472

PR Details

  • Add a new param for createService for a list of plugin IDs
  • remove the params for base paths, and use default values instead
  • do not install the default DB plugin when jovu asks to install any DB plugin

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented May 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d3106a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@mulygottlieb mulygottlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on updating OpenAI platform manually

@mulygottlieb mulygottlieb merged commit 0af4e5f into next May 13, 2024
11 checks passed
@mulygottlieb mulygottlieb deleted the feat/jovu-create-serviec-with-plugins branch May 13, 2024 13:06
@overbit overbit mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants