Feat: upgrade ubuntu image to be latest for github actions #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skim-amplify
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
I normally don't like using the latest version for 3rd party things b/c unexpected things can happen so it's better to set to a specific version then explicitly update version and test... but since this is not a critical public/client facing thing... lets live on the edge a little!!! 😬 🤞
|
but seriously, I'd also be ok with you setting this to ubuntu-22.04 😬 |
|
I'm open to all the version so I'll switch it to 22.04. Either ways it can break on the newest latest image or we don't touch this for many months and didn't notice the image has been gone for a quarter of a year 😛 |
rddimon
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like Github stopped supporting the ubuntu-18.04 image for their Github actions. The recommendation is to use the latest version or 20.04 or 22.04.