Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing API id only when defined #178

Merged

Conversation

attila
Copy link
Contributor

@attila attila commented Jan 10, 2019

This fixes a bug where having any custom data defined in provider data
will trigger a ValidationError because the existing API id is null
or undefined.

A typical use case is when provider data contains API key definitions and the plugin cannot deploy new stages anymore. Existing stages will still work though.

provider:
  name: aws
  runtime: ${opt:runtime, 'nodejs8.10'}
  stage: ${opt:stage}
  region: eu-west-1
  apiGateway:
    apiKeySourceType: HEADER
# [...]

This fixes #177

This fixes a bug where having any custom data defined in provider
will trigger a ValidationError because the existing API id is null
or undefined.
Copy link
Collaborator

@jconstance-amplify jconstance-amplify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much for the improvement!

@jconstance-amplify jconstance-amplify merged commit a6d8ea2 into amplify-education:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pathmapping validation error: restApiId is null
2 participants