WIP: Add ability to specify tags - #254

[fdobrovolny]

Fixes #254

Description of Issue Fixed
Missing ability to specify custom domain tags.

custom:
  customDomain:
    domainName: foo.example.tld
    tags:
      Owner: myowner
      Environment: myenv
      Department: mydept

Changes proposed in this pull request:

• Add ability to specify tags

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[aoskotsky-amplify]

Thanks for this PR!

Serverless Framework already has config options for stackTags and tags in the provider section https://www.serverless.com/framework/docs/providers/aws/guide/serverless.yml/. Would it make sense to change this to read from those values instead of adding new options to the customDomain section?

[fdobrovolny]

@aoskotsky-amplify Oh it would probably make sense to do so. Now I'm thinking would correct approach be to use tags on customDomain merged with tags as they are considered service-wide?

[aoskotsky-amplify]

Yea merging works too or just removing the option to specify the custom domain level tags. I wonder what the use cases are for setting a tag on the domain but not on the service itself

[huksley]

Any chance to have option to tag domain available? I tag all created AWS resources.

[wbruno]

its is not just the domain, but custom domain name and API Gateway also need to be tagged.
how can I help here?