Add config option to avoid automatically deleting an APIGW domain when other base path mappings exist #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 24, 2020 11:39
…her path mappings still exist on them
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -137,6 +137,7 @@ securityPolicy | tls_1_2 | The security policy to apply to the custom domain nam | |||
| allowPathMatching | false | When updating an existing api mapping this will match on the basePath instead of the API ID to find existing mappings for an upsate. This should only be used when changing API types. For example, migrating a REST API to an HTTP API. See Changing API Types for more information. | | |||
| | autoDomain | `false` | Toggles whether or not the plugin will run `create_domain/delete_domain` as part of `sls deploy/remove` so that multiple commands are not required. | | |||
| | autoDomainWaitFor | `120` | How long to wait for create_domain to finish before starting deployment if domain does not exist immediately. | | |||
| | preserveExternalPathMappings | `false` | When `autoDomain` is set to true, and a deployment is removed, setting this wto `true` checks for additional API Gateway base path mappings before automatically deleting the domain, and avoids doing so if they exist. | | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request: Add config option to avoid automatically deleting an APIGW domain when other base path mappings exist
When
autoDomainis set totruein this plugin, runningsls removeon a deployed service will remove the APIGW custom domain regardless of whether base path mappings exist other than the one the plugin defines for this service.This change introduces a
preserveExternalPathMappingsconfig option to check for other path mappings - either defined through this plugin in other services, or otherwise externally - before removing the custom domain.When this is enabled, in a scenario where n>1 deployed services use this plugin, and are set to the same
customDomain.domainName, the n...n-1 services to be removed should NOT remove the custom domain, whereas the nth will.